Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run yarn install in action #49

Draft
wants to merge 1 commit into
base: jordan-mele_overhaul-experiment
Choose a base branch
from

Conversation

Silic0nS0ldier
Copy link
Contributor

This (incomplete WIP) prototype aims to shift yarn install into the execution phase so that;

  1. Less time is spent in the analysis phase (hurts query performance).
  2. Allow Bazel to cache node_modules generation on its own.

The aim is for little (if any) change to be necessary beyond the repo rule invocation itself. Consumers of node_modules (e.g. custom rules) will likely need to be refactored in response to source files now being in a different location. nodejs_binary executables should "just work" as runfiles pushes everything into a consistent directory structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant